Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return a new indexer rather than a pointer to the same object #45

Merged
merged 1 commit into from
May 3, 2024
Merged

Return a new indexer rather than a pointer to the same object #45

merged 1 commit into from
May 3, 2024

Conversation

rsevilla87
Copy link
Member

@rsevilla87 rsevilla87 commented Apr 29, 2024 •
edited
Loading

Type of change

  • Refactor
  • New feature
  • Bug fix
  • Optimization
  • Documentation Update

Description

This change will permit creating multiple indexers of the same type

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.

Testing

  • Please describe the System Under Test.
  • Please provide detailed steps to perform tests related to this code change.
  • How were the fix/results from this change verified? Please provide relevant screenshots or results.

@rsevilla87 rsevilla87 added the enhancement New feature or request label Apr 29, 2024
@rsevilla87 rsevilla87 requested a review from vishnuchalla April 29, 2024 10:01
@rsevilla87 rsevilla87 mentioned this pull request Apr 29, 2024
Merged
7 tasks
vishnuchalla
vishnuchalla approved these changes May 1, 2024
View reviewed changes
Copy link
Collaborator

@vishnuchalla vishnuchalla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rsevilla87 rsevilla87 merged commit 35a376f into cloud-bulldozer:main May 3, 2024
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vishnuchalla vishnuchalla vishnuchalla approved these changes

@shashank-boyapally shashank-boyapally Awaiting requested review from shashank-boyapally

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rsevilla87 @vishnuchalla